Skip to content

[24.0 backport] builder: pass host-gateway IP as worker label#45790

Merged
thaJeztah merged 1 commit intomoby:24.0from
crazy-max:24.0_backport_fix-host-gateway
Jun 23, 2023
Merged

[24.0 backport] builder: pass host-gateway IP as worker label#45790
thaJeztah merged 1 commit intomoby:24.0from
crazy-max:24.0_backport_fix-host-gateway

Conversation

@crazy-max
Copy link
Member

(cherry picked from commit 21e50b8)

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

We missed a case when parsing extra hosts from the dockerfile
frontend so the build fails.

To handle this case we need to set a dedicated worker label
that contains the host gateway IP so clients like Buildx
can just set the proper host:ip when parsing extra hosts
that contain the special string "host-gateway".

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
(cherry picked from commit 21e50b8)
@thaJeztah thaJeztah marked this pull request as ready for review June 22, 2023 20:57
@thaJeztah thaJeztah requested a review from tonistiigi as a code owner June 22, 2023 20:57
@thaJeztah thaJeztah added this to the 24.0.3 milestone Jun 22, 2023
@thaJeztah
Copy link
Member

thaJeztah commented Jun 22, 2023

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 8b61625 into moby:24.0 Jun 23, 2023
@crazy-max crazy-max deleted the 24.0_backport_fix-host-gateway branch June 23, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants