[24.0 backport] seccomp: always allow name_to_handle_at(2)#45833
Merged
[24.0 backport] seccomp: always allow name_to_handle_at(2)#45833
Conversation
Signed-off-by: Vitor Anjos <bartier@users.noreply.github.com> (cherry picked from commit fdc9b7c) Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com>
bartier
approved these changes
Jun 27, 2023
thaJeztah
previously requested changes
Jun 28, 2023
Member
thaJeztah
left a comment
There was a problem hiding this comment.
leaving a "request changes" pending outcome of #45766 (comment)
Based on the analysis on [the previous PR][1]. [1]: moby#45766 (review) Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com> (cherry picked from commit b335e3d) Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com>
corhere
approved these changes
Jun 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #45518
Hi there, this is my first PR here, so please feel free to point me out if anything is wrong with this contribution. I looked the #45518 issue and I believe this could be a fix.
- What I did
Removed the function from the filtered syscalls as
name_to_handle_at(2)is in fact innocuous and safe- How I did it
@neersighted help at comment
- How to verify it
N/A
- Description for the changelog
Remove name_to_handle_at(2) from filtered syscalls
- A picture of a cute animal (not mandatory but encouraged)
