liverestore: Don't remove --rm containers on restart#46857
Merged
vvoland merged 2 commits intomoby:masterfrom Nov 30, 2023
Merged
liverestore: Don't remove --rm containers on restart#46857vvoland merged 2 commits intomoby:masterfrom
--rm containers on restart#46857vvoland merged 2 commits intomoby:masterfrom
Conversation
thaJeztah
reviewed
Nov 28, 2023
2be58fb to
3eb9f78
Compare
When live-restore is enabled, containers with autoremove enabled shouldn't be forcibly killed when engine restarts. They still should be removed if they exited while the engine was down though. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
3eb9f78 to
c5ea3d5
Compare
cpuguy83
requested changes
Nov 28, 2023
akerouanton
approved these changes
Nov 29, 2023
Member
akerouanton
left a comment
There was a problem hiding this comment.
LGTM. Thanks for taking care of this!
Replace `time.Sleep` with a poll that checks if process no longer exists to avoid possible race condition. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
936e41b to
3a0af5a
Compare
Contributor
Author
|
FYI, the last force push is just a small wording correction: - return poll.Continue("waiting for process to be finish")
+ return poll.Continue("waiting for process to finish") |
rumpl
approved these changes
Nov 30, 2023
Contributor
Author
|
Thanks for reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When live-restore is enabled, containers with autoremove enabled shouldn't be forcibly killed when engine restarts.
- What I did
- How I did it
Added extra check and integration test.
- How to verify it
TestLiveRestore
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)