[24.0 backport] liverestore: Don't remove --rm containers on restart#46869
Merged
[24.0 backport] liverestore: Don't remove --rm containers on restart#46869
--rm containers on restart#46869Conversation
When live-restore is enabled, containers with autoremove enabled shouldn't be forcibly killed when engine restarts. They still should be removed if they exited while the engine was down though. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> (cherry picked from commit c5ea3d5) Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Replace `time.Sleep` with a poll that checks if process no longer exists to avoid possible race condition. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> (cherry picked from commit 3a0af5a) Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--rmcontainers on restart #46857When live-restore is enabled, containers with autoremove enabled shouldn't be forcibly killed when engine restarts.
(cherry picked from commit 3a0af5a)
(unclean cherry-pick)
- What I did
- How I did it
Added extra check and integration test.
- How to verify it
TestLiveRestore
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)