daemon: remove configsSupported, secretsSupported utilities#48703
Merged
thaJeztah merged 2 commits intomoby:masterfrom Oct 23, 2024
Merged
daemon: remove configsSupported, secretsSupported utilities#48703thaJeztah merged 2 commits intomoby:masterfrom
thaJeztah merged 2 commits intomoby:masterfrom
Conversation
This utility was originally added in 9e9fc7b at which time it was not yet implemented for Windows, so this utility was used to print a warning when trying to use it on that platform. Windows support was added in e0d533b, which kept the utility, but adjusted it to support for both Windows and Linux, and excluding any other platform. Let's remove this utility, given that we currently only support Windows and Linux (there's been some partial support for other platforms, but they are very likely broken in many ways). Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This utility was originally added in 3716ec2 at which time it was not yet implemented for Windows, so this utility was used to print a warning when trying to use it on that platform. Windows support was added in bd4e8aa, which kept the utility, but adjusted it to support for both Windows and Linux, and excluding any other platform. Let's remove this utility, given that we currently only support Windows and Linux (there's been some partial support for other platforms, but they are very likely broken in many ways). Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
commented
Oct 20, 2024
| return err | ||
| } | ||
|
|
||
| c.SecretReferences = refs |
Member
Author
There was a problem hiding this comment.
Interestingly, the Configs implementation is slightly different here, and it appends, not replaces;
Line 21 in b0632b2
austinvazquez
approved these changes
Oct 20, 2024
robmry
approved these changes
Oct 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
daemon: remove configsSupported utility
This utility was originally added in 9e9fc7b
at which time it was not yet implemented for Windows, so this utility was
used to print a warning when trying to use it on that platform.
Windows support was added in e0d533b, which
kept the utility, but adjusted it to support for both Windows and Linux, and
excluding any other platform.
Let's remove this utility, given that we currently only support Windows and
Linux (there's been some partial support for other platforms, but they are
very likely broken in many ways).
daemon: remove secretsSupported utility
This utility was originally added in 3716ec2
at which time it was not yet implemented for Windows, so this utility was
used to print a warning when trying to use it on that platform.
Windows support was added in bd4e8aa, which
kept the utility, but adjusted it to support for both Windows and Linux, and
excluding any other platform.
Let's remove this utility, given that we currently only support Windows and
Linux (there's been some partial support for other platforms, but they are
very likely broken in many ways).