profiles/apparmor, seccomp: migrate to separate module#50481
Merged
austinvazquez merged 1 commit intomoby:masterfrom Jul 22, 2025
Merged
profiles/apparmor, seccomp: migrate to separate module#50481austinvazquez merged 1 commit intomoby:masterfrom
austinvazquez merged 1 commit intomoby:masterfrom
Conversation
thaJeztah
commented
Jul 22, 2025
vendor.mod
Outdated
Comment on lines
10
to
13
| replace ( | ||
| github.com/moby/profiles/apparmor => github.com/moby/profiles/apparmor v0.0.0-20250722153716-c936cc7b4074 | ||
| github.com/moby/profiles/seccomp => github.com/moby/profiles/seccomp v0.0.0-20250722153716-c936cc7b4074 | ||
| ) |
Member
Author
There was a problem hiding this comment.
Go really doesn't like submodules; it happily took github.com/moby/profiles/apparmor, but then didn't know what to do with github.com/moby/profiles/seccomp (module found but doesn't have package).
Possibly it took the root of the repo, then used apparmor as a package not a module
a81b84c to
0d68120
Compare
Member
Author
|
Ah, looks like we have a CLI integration test that uses the JSON file that was in it, but now moved to the vendor directory; |
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
0d68120 to
a600da9
Compare
dmcgowan
approved these changes
Jul 22, 2025
Contributor
|
Bringing this in to unblock some of the daemon module work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)