client: remove deprecated types and functions#50485
Merged
austinvazquez merged 5 commits intomoby:masterfrom Jul 23, 2025
Merged
client: remove deprecated types and functions#50485austinvazquez merged 5 commits intomoby:masterfrom
austinvazquez merged 5 commits intomoby:masterfrom
Conversation
The `NewClient` and `NewEnvClient` function were deprecated in 2018 through 772edd0, with the deprecation message updated in a68ae4a and 6b9968e to make sure it's properly identified as deprecated. Now that the client is in a new module, we can remove the old. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This function was only used internally, and marked deprecated in 846b227. Now that the client is in a new module, we can remove the old. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This function was marked deprecated in 7aa7369, and is no longer used. Now that the client is in a new module, we can remove the old. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This function was deprecated in 639a121. Now that the client is in a new module, we can remove the old. This; - Removes the `Client.ImageInspectWithRaw` implementation. - Removes `ImageAPIClient.ImageInspectWithRaw` from the `ImageAPIClient` interface. - Removes `APIClient.ImageInspectWithRaw` from the `APIClient` interface. - Removes `ImageAPIClientDeprecated.ImageInspectWithRaw` from the `ImageAPIClientDeprecated`. - Removes the `ImageAPIClientDeprecated` interface. Note that the `ImageAPIClientDeprecated` interface itself was not marked as deprecated, but it has no known external users, and it has no remaining definitions. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This interface was marked deprecated in 2997c0d. Now that the client is in a new module, we can remove the old. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
vvoland
approved these changes
Jul 23, 2025
austinvazquez
approved these changes
Jul 23, 2025
This was referenced Sep 5, 2025
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to:
Manifestsfield #48264client: remove deprecated NewClient and NewEnvClient functions
The
NewClientandNewEnvClientfunction were deprecated in 2018through 772edd0, with the deprecation
message updated in a68ae4a and
6b9968e to make sure it's properly
identified as deprecated.
Now that the client is in a new module, we can remove the old.
client: remove deprecated ErrorConnectionFailed helper
This function was only used internally, and marked deprecated in
846b227.
Now that the client is in a new module, we can remove the old.
client: remove deprecated IsErrNotFound helper
This function was marked deprecated in 7aa7369,
and is no longer used.
Now that the client is in a new module, we can remove the old.
client: remove deprecated ImageInspectWithRaw
This function was deprecated in 639a121.
Now that the client is in a new module, we can remove the old.
This;
Client.ImageInspectWithRawimplementation.ImageAPIClient.ImageInspectWithRawfrom theImageAPIClientinterface.APIClient.ImageInspectWithRawfrom theAPIClientinterface.ImageAPIClientDeprecated.ImageInspectWithRawfrom theImageAPIClientDeprecated.ImageAPIClientDeprecatedinterface.Note that the
ImageAPIClientDeprecatedinterface itself was not markedas deprecated, but it has no known external users, and it has no remaining
definitions.
client: remove deprecated CommonAPIClient interface
This interface was marked deprecated in 2997c0d.
Now that the client is in a new module, we can remove the old.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)