contrib: remove mac-install-bundle.sh and editorconfig#50607
Merged
vvoland merged 2 commits intomoby:masterfrom Aug 4, 2025
Merged
contrib: remove mac-install-bundle.sh and editorconfig#50607vvoland merged 2 commits intomoby:masterfrom
mac-install-bundle.sh and editorconfig#50607vvoland merged 2 commits intomoby:masterfrom
Conversation
This script was added in 6860c10 to allow testing a custom daemon in Docker Desktop, but has not been maintained since, and likely no longer functional, so let's remove. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This file was added in 962f347, at which time there already were doubts about it being useful. For Go, `gofmt` already dictates formatting (and proper editors would integrat with that). For other languages, most editors would already have a config, and our CI validates formatting for various files. Give that the file was never updated since it was added, it's fair to say that it's unmaintained. Let's remove. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
mac-install-bundle.sh and editorconfig
AkihiroSuda
approved these changes
Aug 4, 2025
vvoland
approved these changes
Aug 4, 2025
Sorry for intruding here, but what do you expect to change in a config file like for editorconfig, which sets editor settings? Those settings rarely change in a project and EditorConfig itself is pretty stable. Just because it has not changed in a while, doesn't say anything about if it's working as intended. Removing it just because it was not changed and you don't need it for your editor is irritating. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
contrib: remove mac-install-bundle.sh
This script was added in 6860c10 to allow testing a custom daemon in Docker Desktop, but has not been maintained since, and likely no longer functional, so let's remove.
contrib: remove editorconfig
This file was added in 962f347, at which
time there already were doubts about it being useful. For Go,
gofmtalready dictates formatting (and proper editors would integrat with
that). For other languages, most editors would already have a config,
and our CI validates formatting for various files.
Give that the file was never updated since it was added, it's fair
to say that it's unmaintained. Let's remove.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)