api/t/ctr: drop NetworkSettingsBase, DefaultNetworkSettings#50846
Merged
thaJeztah merged 2 commits intomoby:masterfrom Sep 11, 2025
Merged
api/t/ctr: drop NetworkSettingsBase, DefaultNetworkSettings#50846thaJeztah merged 2 commits intomoby:masterfrom
thaJeztah merged 2 commits intomoby:masterfrom
Conversation
1178025 to
80416bf
Compare
Member
|
@akerouanton this needs a rebase now |
80416bf to
288b4f1
Compare
Member
Author
|
@robmry asked privately about dropped fields not being returned for older API versions we still support. So here's a summury of when every field was deprecated, etc…
|
288b4f1 to
631d45a
Compare
thaJeztah
reviewed
Sep 9, 2025
631d45a to
0685927
Compare
This comment was marked as outdated.
This comment was marked as outdated.
20 tasks
f3392ee to
26942ec
Compare
26942ec to
90dd0fe
Compare
All the fields in DefaultNetworkSettings were deprecated in Engine v1.9 and scheduled for removal in v17.12. However, they're still return in all supported API versions. As we still need to keep backward compatibility for older API versions, this change leverages the newly added 'compat' package to return these fields despite being removed from the Go struct. Signed-off-by: Albin Kerouanton <albinker@gmail.com>
Except Bridge, all fields of NetworkSettingsBase were deprecated in v1.44, and are actually never set at all. The Bridge field was deprecated in v1.51 but it's only set when the container is connected to the default bridge, and when the daemon is started with the --bridge option set. So, remove all those fields and do not backfill them for older API versions. Signed-off-by: Albin Kerouanton <albinker@gmail.com>
90dd0fe to
b092c8c
Compare
robmry
approved these changes
Sep 11, 2025
thaJeztah
approved these changes
Sep 11, 2025
Member
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
I'll do a quick follow-up to sync the v1.52 swagger
Member
Author
Oh right, we've the 1.52 swagger file already in |
Member
|
Yeah, we probably should; usually we don't cut off the versioned file until it's ready to do the release, but with all the module work, we did that early. I didn't get round to open that PR yet; feel free to open one if you have time. I think we should also repeat the deprecation in the v1.52 changelog; add a bullet that the fields that were deprecated have now been removed from the API response (to be crystal clear they're gone now), wdyt? @akerouanton |
This was referenced Oct 16, 2025
8 tasks
koeleco
pushed a commit
to TOPdesk/pytest-docker-network-fixtures
that referenced
this pull request
Nov 17, 2025
Docker v29 removes the top-level NetworkSettings.IPAddress field; IP addresses are now only available under NetworkSettings.Networks. Fallback to the bridge network entry if the legacy key is absent. See moby/moby#50846 Other changes * Add myself to the authors list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
These structs were deprecated in v28.4, and are now fully removed. The few fields in
NetworkSettingsBasethat were not deprecated are moved toNetworkSettings.- Human readable description for the release notes