api: image inspect: remove temporary backfill for Config fields#50915
Merged
thaJeztah merged 1 commit intomoby:masterfrom Sep 11, 2025
Merged
api: image inspect: remove temporary backfill for Config fields#50915thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
Commit 4dc961d (API v1.50) fixed the type used for Config to point to the correct type, which is the Config struct from the [Docker image spec] (which embeds the [OCI Image Specification] type); however, those types use an omitempty, which wasn't documented as part of the API changes, so f85394d added a temporary backfill for empty fields. This removes that backfill for API v1.52 so that empty image config fields are now omitted. [OCI Image Specification]: https://github.com/opencontainers/image-spec/blob/v1.1.1/specs-go/v1/config.go#L23-L62 [Docker image spec]: https://github.com/moby/docker-image-spec/blob/v1.3.1/specs-go/v1/image.go#L19-L32 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
ff8b10a to
0525ae2
Compare
vvoland
approved these changes
Sep 8, 2025
austinvazquez
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 4dc961d (API v1.50) fixed the type used for Config to point to the correct type, which is the Config struct from the Docker image spec (which embeds the OCI Image Specification type); however, those types use an omitempty, which wasn't documented as part of the API changes, so f85394d added a temporary backfill for empty fields.
This removes that backfill for API v1.52 so that empty image config fields are now omitted.
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)