api/types/network: CreateRequest: remove deprecated CheckDuplicate field#50998
api/types/network: CreateRequest: remove deprecated CheckDuplicate field#50998thaJeztah merged 1 commit intomoby:masterfrom
Conversation
CheckDuplicate is removed in API v1.44, and no longer used by daemons supporting that API version (v25.0.0-beta.1 and up) regardless of the API version used, but it must be set to true when sent to older daemons (see [moby/moby@78479b1]). This patch moves adding the field to the client through an ad-hoc struct so that we don't have to carry the field in the API module. We can remove this once daemon versions v24.0 and lower are no longer expected to be used (when Mirantis Container Runtime v23 is EOL). https://github.com/moby/moby/blob/v2.0.0-beta.0/project/BRANCHES-AND-TAGS.md. This field was removed from API v1.44 and no longer used by daemons supporting that API version (v25.0.0-beta.1 and up) regardless of the API version used, but for older version of the daemon required this option to be set. [moby/moby@78479b1]: moby@78479b1 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
45be835 to
6d0551e
Compare
Based on EOL MCR Versions, I believe MCR v23 has reached EOL in June, and our BRANCHES-AND-TAGS.md is out-of-date. @corhere could you confirm, and update that file if needed? |
akerouanton
left a comment
There was a problem hiding this comment.
LGTM but I'd like to hear from @corhere before we merge this one.
|
Yes, I noticed that, but also STR that there was some extension to that period. In either case, this PR moves the field definition out of the API, making it internal, so we can remove it without having to update the type definitions. |
|
I'm pretty sure v23 has had its last release - but only recently, so could still be in use. I don't think there's any harm in keeping the compatibility code in the client for a short time. |
|
Yeah, I was planning to open a PR to update the branch status for v23, and am working on raising the minimum API version (or at least the "fallback version") for the client, but likely this API version may still be included for some time; I wanted to get this out of the way first. @akerouanton any strong objections? |
akerouanton
left a comment
There was a problem hiding this comment.
Let's get this one in, and we can still drop the anon struct in a folloz-up PR if v23 has reached EOL.
|
MCR 23 has only been EOL for three months and enterprise users are annoyingly slow to upgrade at times. What's the harm in keeping the back-compat anonymous struct in until we raise the client's minimum supported API version to v1.44? |
|
None, but we started discussing whether we could drop support for API version < v1.44. |
|
I see no problem with requiring users of EOL engines to stick with an EOL'd client. |
|
Yeah, my main goal was to remove deprecated things from the Go API; removing some of the fallbacks for old API versions are the next steps, but won't break the Go API compatibility, which makes it easier to do. |
CheckDuplicate is removed in API v1.44, and no longer used by daemons supporting that API version (v25.0.0-beta.1 and up) regardless of the API version used, but it must be set to true when sent to older daemons (see moby@78479b1).
This patch moves adding the field to the client through an ad-hoc struct so that we don't have to carry the field in the API module.
We can remove this once daemon versions v24.0 and lower are no longer expected to be used (when Mirantis Container Runtime v23 is EOL).
This field was removed from API v1.44 and no longer used by daemons supporting that API version (v25.0.0-beta.1 and up) regardless of the API version used, but for older version of the daemon required this option to be set.
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)