client: ContainerCommitOptions: change "Pause" to "NoPause"#51019
Merged
thaJeztah merged 2 commits intomoby:masterfrom Sep 23, 2025
Merged
client: ContainerCommitOptions: change "Pause" to "NoPause"#51019thaJeztah merged 2 commits intomoby:masterfrom
thaJeztah merged 2 commits intomoby:masterfrom
Conversation
Member
Author
|
GitHub having a bad day? 
|
ec1806b to
07e72d1
Compare
Commit [moby/moby@17d870b] (API v1.13, docker v1.1.0) changed the default to pause containers during commit, keeping the behavior opt-in for older API versions. This version-gate was removed in [moby/moby@1b1147e] because API versions lower than v1.23 were no longer supported. However, the client still required opting-in to pausing containers, which is handled by setting the `Pause` field to true by default. This patch changes the client option to reflect the default; after this change, we should also consider changing the API make disabling pause a more explicit option, and to change the "pause" argument to a "no-pause". [moby/moby@17d870b]: moby@17d870b [moby/moby@1b1147e]: moby@1b1147e Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Commit [moby/moby@17d870b] (API v1.13, docker v1.1.0) changed the default to pause containers during commit, keeping the behavior opt-in for older API versions. This version-gate was removed in [moby/moby@1b1147e] because API versions lower than v1.23 were no longer supported. However, the `CreateImageConfig` struct still used `Pause`, and required opting- in to enable pausing. This patch changes the struct to reflect the default. after this change, we should also consider changing the API make disabling pause a more explicit option, and to change the "pause" argument to a "no-pause". [moby/moby@17d870b]: moby@17d870b [moby/moby@1b1147e]: moby@1b1147e Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
07e72d1 to
471f24b
Compare
vvoland
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to:
client: ContainerCommitOptions: change "Pause" to "NoPause"
Commit moby@17d870b (API v1.13, docker v1.1.0) changed the default to pause containers during commit, keeping the behavior opt-in for older API versions. This version-gate was removed in moby@1b1147e because API versions lower than v1.23 were no longer supported.
However, the client still required opting-in to pausing containers, which is handled by setting the
Pausefield to true by default. This patch changes the client option to reflect the default; after this change, we should also consider changing the API make disabling pause a more explicit option, and to change the "pause" argument to a "no-pause".daemon/server/backend: CreateImageConfig: change "Pause" to "NoPause"
Commit moby@17d870b (API v1.13, docker v1.1.0) changed the default to pause
containers during commit, keeping the behavior opt-in for older API versions.
This version-gate was removed in moby@1b1147e because API versions lower
than v1.23 were no longer supported.
However, the
CreateImageConfigstruct still usedPause, and required opting-in to enable pausing. This patch changes the struct to reflect the default.
after this change, we should also consider changing the API make disabling
pause a more explicit option, and to change the "pause" argument to a
"no-pause".
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)