api/types/container: omit Config.OnBuild when empty#51154
Merged
thaJeztah merged 1 commit intomoby:masterfrom Oct 10, 2025
Merged
api/types/container: omit Config.OnBuild when empty#51154thaJeztah merged 1 commit intomoby:masterfrom
Config.OnBuild when empty#51154thaJeztah merged 1 commit intomoby:masterfrom
Conversation
Contributor
Author
|
docker run -it --rm -v ./api:/workspace -w /workspace golang:1.23 go test ./... |
There was a problem hiding this comment.
Pull Request Overview
This PR adds JSON serialization optimization to the container configuration by omitting the OnBuild field when it's empty or zero-valued. This reduces JSON payload size for container configurations that don't use ONBUILD instructions.
- Added
omitempty,omitzeroJSON tags to theOnBuildfield in container configuration - Added comprehensive test coverage to verify empty
OnBuildarrays are omitted during JSON marshaling - Updated API changelog to document the behavioral change
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| api/types/container/config.go | Added omitempty,omitzero JSON tags to OnBuild field |
| api/types/container/config_test.go | Added test to verify OnBuild field omission behavior |
| api/docs/CHANGELOG.md | Documented the API change for container JSON response |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
corhere
reviewed
Oct 9, 2025
bbcaca7 to
554c896
Compare
Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
554c896 to
ac3960a
Compare
Member
|
Flaky test; already has a tracking issue; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Added omit annotations for container configuration
OnBuildfield.- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)