api/types/container: remove support for config mac address#51189
Merged
thaJeztah merged 1 commit intomoby:masterfrom Oct 15, 2025
Merged
Conversation
This change stops daemon support for the container config MacAddress field. Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
austinvazquez
commented
Oct 14, 2025
Contributor
Author
There was a problem hiding this comment.
Can this field be removed from the swagger spec? When client negotiate for older API versions do they use the older swagger specs for support?
Member
There was a problem hiding this comment.
When client negotiate for older API versions do they use the older swagger specs for support?
Yes, clients should use the swagger spec that matches the API version they negociate. It's fine to drop the field from the 1.52 spec.
akerouanton
approved these changes
Oct 15, 2025
robmry
approved these changes
Oct 15, 2025
Contributor
robmry
left a comment
There was a problem hiding this comment.
LGTM - thank you!
I see @thaJeztah's review is requested, so I'll hold off on the merge.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Alternative to #51152
This change stops daemon support for the container config MacAddress field. Clients specifying the field will now receive an error for API v1.52 and onwards.
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)