client/image: Wrap result and options in structs#51227
Merged
austinvazquez merged 6 commits intomoby:masterfrom Oct 22, 2025
Merged
client/image: Wrap result and options in structs#51227austinvazquez merged 6 commits intomoby:masterfrom
austinvazquez merged 6 commits intomoby:masterfrom
Conversation
e24ef59 to
b39c5cf
Compare
vvoland
commented
Oct 20, 2025
Comment on lines
10
to
13
| type ImageSearchResult struct { | ||
| Results []registry.SearchResult | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This one is a bit awkward with Result -> Results -> Result, but I guess it's better to keep it consistent
Member
There was a problem hiding this comment.
We should also consider making this RegistrySearch or ... something something registry, because we only search remote, not local images.
Contributor
Author
There was a problem hiding this comment.
Hmm, Registry sounds good for this one
Member
There was a problem hiding this comment.
Perhaps for these we should use Items ; also see
b39c5cf to
2572f12
Compare
8ca6d1b to
373f2cd
Compare
vvoland
commented
Oct 20, 2025
Comment on lines
+12
to
+20
| type ImageTagOptions struct { | ||
| Source string | ||
| Target string | ||
| } | ||
|
|
||
| type ImageTagResult struct{} | ||
|
|
||
| // ImageTag tags an image in the docker host | ||
| func (cli *Client) ImageTag(ctx context.Context, source, target string) error { | ||
| func (cli *Client) ImageTag(ctx context.Context, options ImageTagOptions) (ImageTagResult, error) { |
Contributor
Author
There was a problem hiding this comment.
For this one I ended up extracting both Source and Target to the options struct to make it easier to distinguish between source vs target image.
f36ab73 to
ee54c64
Compare
thaJeztah
reviewed
Oct 21, 2025
Comment on lines
21
to
24
| // ImageListResult holds the result from ImageList. | ||
| type ImageListResult struct { | ||
| Images []image.Summary | ||
| } |
Member
There was a problem hiding this comment.
Perhaps here as well; Items could work as something we can apply to all the list functions;
@austinvazquez WDYT?
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
ee54c64 to
6819a9f
Compare
austinvazquez
approved these changes
Oct 22, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.