Skip to content

[docker-29.x backport] daemon: Fix image store choice priority for prior graphdriver state#51516

Merged
vvoland merged 2 commits intomoby:docker-29.xfrom
vvoland:51492-docker-29.x
Nov 14, 2025
Merged

[docker-29.x backport] daemon: Fix image store choice priority for prior graphdriver state#51516
vvoland merged 2 commits intomoby:docker-29.xfrom
vvoland:51492-docker-29.x

Conversation

@vvoland
Copy link
Contributor

@vvoland vvoland commented Nov 13, 2025

The priority order for determining image store choice was incorrect when a prior graphdriver existed.

The issue occurred because the prior graphdriver check happened after processing explicit driver configuration, effectively ignoring user intent when prior state existed.

Fix explicit graphdriver configuration (`"storage-driver"`) being treated as containerd snapshotter when prior graphdriver state exists.

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
(cherry picked from commit c5d0e3e)
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
The priority order for determining image store choice was incorrect when
a prior graphdriver existed.

The issue occurred because the prior graphdriver check happened after
processing explicit driver configuration, effectively ignoring user
intent when prior state existed.

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
(cherry picked from commit 391247c)
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@vvoland vvoland added this to the 29.0.1 milestone Nov 13, 2025
@vvoland vvoland self-assigned this Nov 13, 2025
@vvoland vvoland added status/2-code-review impact/changelog area/daemon Core Engine kind/bugfix PR's that fix bugs area/builder/buildkit Build containerd-integration Issues and PRs related to containerd integration labels Nov 13, 2025
@vvoland vvoland merged commit cb6c1c3 into moby:docker-29.x Nov 14, 2025
295 of 308 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/builder/buildkit Build area/daemon Core Engine containerd-integration Issues and PRs related to containerd integration impact/changelog kind/bugfix PR's that fix bugs status/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants