Conversation
bengl
requested changes
Apr 4, 2025
| #![deny(clippy::perf)] | ||
| #![deny(clippy::complexity)] | ||
| #![deny(clippy::correctness)] | ||
| #![deny(clippy::unwrap_used)] |
Member
There was a problem hiding this comment.
These should be left in because they make clippy more strict.
| pub struct Config { | ||
| pub instrumentations: Vec<InstrumentationConfig>, | ||
| pub dc_module: String, | ||
| pub diagnostic_channel_module: String, |
Member
There was a problem hiding this comment.
Let's leave this as dc_module, to keep it consistent with the YAML, which we'd like to be clear, but also concise.
Contributor
There was a problem hiding this comment.
Personally, I like the descriptive name in both places over the "you know what the abbreviation means so you know what the name means" version.
timfish
added a commit
to timfish/orchestrion-js
that referenced
this pull request
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small suggestions, you can discard the PR if you feel it is not useful.