feat: Allow configuring of min/max in histograms by MikeGoldsmith · Pull Request #8095 · open-telemetry/opentelemetry-java

MikeGoldsmith · 2026-02-16T14:55:37Z

Summary

Adds support for disabling min/max recording in histogram aggregations per the OpenTelemetry spec.

Motivation

Some users need the ability to disable min/max recording in histograms. The OpenTelemetry spec requires this parameter for both explicit and exponential histogram aggregations.

Changes

Added HistogramOptions builder to encapsulate histogram behavioral options (currently recordMinMax), providing an extensible place for future options without method overload explosion
Added Aggregation.explicitBucketHistogram(List<Double>, HistogramOptions) and Aggregation.base2ExponentialBucketHistogram(int, int, HistogramOptions)
Updated aggregator implementations to conditionally record min/max
Integrated with declarative config — passes record_min_max from YAML to SDK
Backward compatible — existing methods without HistogramOptions default to recordMinMax=true
Updated public API diff doc with new methods and types

Testing

Added DoubleExplicitBucketHistogramAggregatorTest.testRecordMinMaxDisabled — verifies min/max not tracked when disabled for explicit histograms
Added DoubleBase2ExponentialHistogramAggregatorTest.testRecordMinMaxDisabled — verifies min/max not tracked when disabled for exponential histograms
Updated existing tests to use new constructor signatures

linux-foundation-easycla · 2026-02-16T14:55:45Z

The committers listed above are authorized under a signed CLA.

✅ login: MikeGoldsmith / name: Mike Goldsmith (3c5ac63, 78e2805, dae105e)

Supports disabling min/max recording to work around GCP min/max handling issues. Backward compatible - defaults to true.

Verifies min/max not tracked when disabled.

codecov · 2026-02-16T15:43:37Z

Codecov Report

❌ Patch coverage is 86.25000% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.31%. Comparing base (d14eb6c) to head (dae105e).

Files with missing lines	Patch %	Lines
...java/io/opentelemetry/sdk/metrics/Aggregation.java	46.15%	7 Missing ⚠️
...gator/DoubleExplicitBucketHistogramAggregator.java	81.81%	0 Missing and 2 partials ⚠️
.../sdk/metrics/Base2ExponentialHistogramOptions.java	92.30%	1 Missing ⚠️
...ry/sdk/metrics/ExplicitBucketHistogramOptions.java	80.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #8095      +/-   ##
============================================
- Coverage     90.34%   90.31%   -0.03%     
- Complexity     7646     7650       +4     
============================================
  Files           841      843       +2     
  Lines         23002    23055      +53     
  Branches       2293     2307      +14     
============================================
+ Hits          20781    20823      +42     
- Misses         1508     1516       +8     
- Partials        713      716       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jack-berg

Couple small comments, but looks good overall. Thanks!

sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/Aggregation.java

...main/java/io/opentelemetry/sdk/metrics/internal/view/ExplicitBucketHistogramAggregation.java

...o/opentelemetry/sdk/metrics/internal/aggregator/DoubleExplicitBucketHistogramAggregator.java

…nto mike/disable-histogram-minmax

@SInCE

- Remove @SInCE annotations (added during release flow) - Remove old create() overloads without recordMinMax, update callers - Remove redundant // read-only comment on final primitive field Claude claude-sonnet-4-6 assisted with this change.

...rc/test/java/io/opentelemetry/sdk/extension/incubator/fileconfig/AggregationFactoryTest.java

Declarative config tests compare aggregation equality via toString(), so recordMinMax must be included for the comparisons to be valid. Claude claude-sonnet-4-6 assisted with this change.

jack-berg

Will leave open for a few days to see if any other @open-telemetry/java-approvers have feedback about the new public API surface area

jkwatson · 2026-02-24T10:05:05Z

Will leave open for a few days to see if any other @open-telemetry/java-approvers have feedback about the new public API surface area

I finally got a chance to look at this. I'm slightly concerned about adding a simple boolean option to this. If we end up with more of them in the future, the API surface could end up exploding in non-optimal ways. What would y'all think about creating an AggregationOptions type that would encapsulate this new option, and also provide a place to put future options, when/if they crop up?

MikeGoldsmith · 2026-02-24T10:13:28Z

Will leave open for a few days to see if any other @open-telemetry/java-approvers have feedback about the new public API surface area

I finally got a chance to look at this. I'm slightly concerned about adding a simple boolean option to this. If we end up with more of them in the future, the API surface could end up exploding in non-optimal ways. What would y'all think about creating an AggregationOptions type that would encapsulate this new option, and also provide a place to put future options, when/if they crop up?

~~Yeah, a wrapper type so we don't keep adding more and more options is a good idea 👍🏻~~

Thought more on this, and I'm not sure. Other existing Histogram options (maxBuckets, maxScale, and bucketBoundaries) all use the same in-line design. Adding an Options class just for recordMinMax feels excessive, especially if we don't know of any other options that might come along?

@jkwatson is this something you feel strongly about adding?

…nto mike/disable-histogram-minmax

jkwatson · 2026-02-24T10:35:33Z

Will leave open for a few days to see if any other @open-telemetry/java-approvers have feedback about the new public API surface area

I finally got a chance to look at this. I'm slightly concerned about adding a simple boolean option to this. If we end up with more of them in the future, the API surface could end up exploding in non-optimal ways. What would y'all think about creating an AggregationOptions type that would encapsulate this new option, and also provide a place to put future options, when/if they crop up?

~~Yeah, a wrapper type so we don't keep adding more and more options is a good idea 👍🏻~~

Thought more on this, and I'm not sure. Other existing Histogram options (maxBuckets, maxScale, and bucketBoundaries) all use the same in-line design. Adding an Options class just for recordMinMax feels excessive, especially if we don't know of any other options that might come along?

@jkwatson is this something you feel strongly about adding?

Maybe we should put all the current options into an HistogramAggregationOptions as well, rather than continue the sub-optimal combinatoric parameter approach?

MikeGoldsmith · 2026-02-24T10:43:30Z

Will leave open for a few days to see if any other @open-telemetry/java-approvers have feedback about the new public API surface area

I finally got a chance to look at this. I'm slightly concerned about adding a simple boolean option to this. If we end up with more of them in the future, the API surface could end up exploding in non-optimal ways. What would y'all think about creating an AggregationOptions type that would encapsulate this new option, and also provide a place to put future options, when/if they crop up?

~~Yeah, a wrapper type so we don't keep adding more and more options is a good idea 👍🏻~~
Thought more on this, and I'm not sure. Other existing Histogram options (maxBuckets, maxScale, and bucketBoundaries) all use the same in-line design. Adding an Options class just for recordMinMax feels excessive, especially if we don't know of any other options that might come along?
@jkwatson is this something you feel strongly about adding?

Maybe we should put all the current options into an HistogramAggregationOptions as well, rather than continue the sub-optimal combinatoric parameter approach?

Sure, I could look at doing that.

Replace boolean recordMinMax params on Aggregation factory methods with a HistogramOptions builder, providing a single extensible place for future histogram options without requiring new method overloads. Claude claude-sonnet-4-6 assisted with this change.

MikeGoldsmith · 2026-02-24T11:47:58Z

@jkwatson I've updated to use an options builder for the recordMinMax optional parameter. The other params are required so don't really fit into the options builder. Let me know what you think 😄

cc @jack-berg as the implementation has changed a bit since your approval

sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/HistogramOptions.java

Claude claude-sonnet-4-6 assisted with this change.

…ns builders Replaces HistogramOptions with per-type options builders that include all histogram parameters (boundaries/scale/maxBuckets + recordMinMax). Deprecates positional-param overloads which now delegate to the options-based methods. Assisted-by: Claude Sonnet 4.6

…nto mike/disable-histogram-minmax

jack-berg · 2026-03-01T02:33:23Z

sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/ExplicitBucketHistogramOptions.java

+ *
+ * @see Aggregation#explicitBucketHistogram(ExplicitBucketHistogramOptions)
+ */
+public final class ExplicitBucketHistogramOptions {


I think we should model these after SpanLimits, LogLimits, RetryPolicy. Differences:

AutoValue for the record class and the builder

"get" prefix for accessors, i.e. "getBucketBoundaries" rather than "bucketBoundaries"

Benefits are mostly just consistency, but we do get hashCode and equals implementations for free.

I agree. Consistency is pretty important. Sorry for all the thrash, @MikeGoldsmith , but getting these APIs right is super important, as we can never change them once they are in and stable.

Yeah, that's fine - I want them to be correct too 👍🏻

I updated the options builders to match what I found in the other options classes (spanlimits, loglimits, retrypolicy) in 78e2805.

Let me know what you both both think 😄

- Use AutoValue + @AutoValue.Builder for ExplicitBucketHistogramOptions and Base2ExponentialHistogramOptions, providing generated hashCode/equals - Rename accessors to use get* prefix (getBucketBoundaries, getRecordMinMax, getMaxBuckets, getMaxScale) for consistency with other SDK config types - Add getDefault() and toBuilder() to both options types - Move maxBuckets/maxScale validation into Base2ExponentialHistogramOptions Builder.build() using the autoBuild() pattern, removing it from the internal aggregation class Assisted-by: Claude Sonnet 4.6 Made-with: Cursor

…nto mike/disable-histogram-minmax

Update to use Base2ExponentialHistogramOptions builder instead of the deprecated base2ExponentialBucketHistogram(int, int) positional overload. Made-with: Cursor

MikeGoldsmith · 2026-03-02T12:46:55Z

FYI we had a test failure in PrometheusMetricReaderTest because it uses OtelDeprecatedApiUsage, so I updated that to also use the updated API in dae105e

MikeGoldsmith requested a review from a team as a code owner February 16, 2026 14:55

MikeGoldsmith added 2 commits February 16, 2026 14:56

Add recordMinMax param to histogram aggregations per spec

c01ceab

Supports disabling min/max recording to work around GCP min/max handling issues. Backward compatible - defaults to true.

Add tests for recordMinMax=false behavior

8f364a5

Verifies min/max not tracked when disabled.

MikeGoldsmith force-pushed the mike/disable-histogram-minmax branch from 9caaa69 to 8f364a5 Compare February 16, 2026 14:56

MikeGoldsmith mentioned this pull request Feb 16, 2026

Support RecordMinMax for histogram and exponential histogram aggregations #7859

Open

Update API diff for recordMinMax methods

e584f31

MikeGoldsmith changed the title ~~feat: Add recordMinMax parameter to histogram aggregations~~ feat: Allow configuring of min/max in histograms Feb 16, 2026

Add tests for recordMinMax parameter in AggregationFactory

6e30bcb

jack-berg reviewed Feb 19, 2026

View reviewed changes

jack-berg approved these changes Feb 19, 2026

View reviewed changes

MikeGoldsmith added 2 commits February 20, 2026 12:38

Merge branch 'main' of github.com:open-telemetry/opentelemetry-java i…

3d34d6c

…nto mike/disable-histogram-minmax

Address review feedback

849cc50

- Remove @SInCE annotations (added during release flow) - Remove old create() overloads without recordMinMax, update callers - Remove redundant // read-only comment on final primitive field Claude claude-sonnet-4-6 assisted with this change.

MikeGoldsmith force-pushed the mike/disable-histogram-minmax branch from a681c40 to 849cc50 Compare February 20, 2026 15:15

jack-berg reviewed Feb 20, 2026

View reviewed changes

...rc/test/java/io/opentelemetry/sdk/extension/incubator/fileconfig/AggregationFactoryTest.java Outdated Show resolved Hide resolved

MikeGoldsmith added 2 commits February 20, 2026 15:32

Include recordMinMax in Aggregation toString()

7aaab68

Declarative config tests compare aggregation equality via toString(), so recordMinMax must be included for the comparisons to be valid. Claude claude-sonnet-4-6 assisted with this change.

Apply spotless formatting

ec038ac

jack-berg approved these changes Feb 20, 2026

View reviewed changes

Merge branch 'main' of github.com:open-telemetry/opentelemetry-java i…

d944b29

…nto mike/disable-histogram-minmax

jkwatson reviewed Feb 25, 2026

View reviewed changes

sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/HistogramOptions.java Outdated Show resolved Hide resolved

jkwatson reviewed Feb 25, 2026

View reviewed changes

sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/HistogramOptions.java Outdated Show resolved Hide resolved

MikeGoldsmith added 2 commits February 27, 2026 14:11

Rename isRecordMinMax() to recordMinMax()

e704187

Claude claude-sonnet-4-6 assisted with this change.

Merge branch 'main' of github.com:open-telemetry/opentelemetry-java i…

565b91d

…nto mike/disable-histogram-minmax

jkwatson requested a review from jack-berg February 28, 2026 22:49

jack-berg reviewed Mar 1, 2026

View reviewed changes

MikeGoldsmith added 3 commits March 2, 2026 10:54

Merge branch 'main' of github.com:open-telemetry/opentelemetry-java i…

3c5ac63

…nto mike/disable-histogram-minmax

Fix deprecated API usage in PrometheusMetricReaderTest

dae105e

Update to use Base2ExponentialHistogramOptions builder instead of the deprecated base2ExponentialBucketHistogram(int, int) positional overload. Made-with: Cursor

Conversation

MikeGoldsmith commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Motivation

Changes

Testing

Uh oh!

linux-foundation-easycla bot commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jack-berg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jack-berg left a comment

Choose a reason for hiding this comment

Uh oh!

jkwatson commented Feb 24, 2026

Uh oh!

MikeGoldsmith commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jkwatson commented Feb 24, 2026

Uh oh!

MikeGoldsmith commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MikeGoldsmith commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jack-berg Mar 1, 2026

Choose a reason for hiding this comment

Uh oh!

jkwatson Mar 1, 2026

Choose a reason for hiding this comment

Uh oh!

MikeGoldsmith Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

MikeGoldsmith Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

MikeGoldsmith commented Mar 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MikeGoldsmith commented Feb 16, 2026 •

edited

Loading

linux-foundation-easycla bot commented Feb 16, 2026 •

edited

Loading

codecov bot commented Feb 16, 2026 •

edited

Loading

MikeGoldsmith commented Feb 24, 2026 •

edited

Loading

MikeGoldsmith commented Feb 24, 2026 •

edited

Loading

MikeGoldsmith commented Feb 24, 2026 •

edited

Loading