GitHub Code Quality in public preview #177488
Replies: 40 comments 94 replies
-
|
This is an amazing feature! Especially great to see a blend of AI scan and CodeQL. I have couple of questions:
|
Beta Was this translation helpful? Give feedback.
-
|
Also, we just turned on GitHub Code Quality for our open source organisation! Check it out here: github.com/logchange Thanks to the GitHub team for creating this feature — it’s already making our reviews smoother! 🚀 |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Great to see this come to public preview! Do you anticipate enabling additional quality checkers to provide results to GitHub Code Quality, similar to how GHAS supports uploading SARIF files from tools which are capable of exporting data in that format? For example, our developers already use popular tools for their respective ecosystems (e.g., ruff for Python) locally and in their pipelines, and being able to understand these code quality findings at scale through GitHub Code Quality would be incredibly helpful |
Beta Was this translation helpful? Give feedback.
-
|
This is great and looks like its finding some real issues. It really needs to run on PR and allow the repo to gate based on level (i.e. Warning Error) |
Beta Was this translation helpful? Give feedback.
-
|
Is there some way to get the Code Quality info via the Github API's? |
Beta Was this translation helpful? Give feedback.
-
Did you forget to mention Rust or is that somehow not supported despite being the most loved language for several years in a row (according to stackoverflow)? 🤔 |
Beta Was this translation helpful? Give feedback.
-
|
I tried to set code quality thresholds for pull requests |
Beta Was this translation helpful? Give feedback.
-
|
It needs to be easy to tell Code Quality to ignore specific files (especially minified files). https://github.com/check-spelling-sandbox/adk-python/security/quality
|
Beta Was this translation helpful? Give feedback.
-
|
Consider:
Compare: https://github.com/check-spelling-sandbox/adk-python/security/quality/rules/js%2Fuseless-expression
|
Beta Was this translation helpful? Give feedback.
-
|
This has the potential to be so useful! Reviewing your work and getting valuable feedback is so crucial, and this will be another way for organizations to do so; even individuals can improve their work from such feedback. Good stuff! |
Beta Was this translation helpful? Give feedback.
-
|
I found this dashboard really helpful, a couple of potential features I'd love to see
|
Beta Was this translation helpful? Give feedback.
-
|
I see that CodeQL already supports C / C++, are there any plans to extend this feature to officially support them too? |
Beta Was this translation helpful? Give feedback.
-
|
Hey @carogalvin - congrats on the public preview release! I’m using it in a few personal projects, and love it! Do you see this becoming available in GHES in a future release? |
Beta Was this translation helpful? Give feedback.
-
|
@carogalvin is there something else I need to do? I checked a few repos and not available in any. |
Beta Was this translation helpful? Give feedback.
-
|
Still can't overlay test coverage. 😏 |
Beta Was this translation helpful? Give feedback.
-
|
Wanted to test on our GHE, but doesn't worked with forked pull requests... |
Beta Was this translation helpful? Give feedback.
-
|
The new dismiss function is very cumbersome especially when it has multiple false positives. You have no click the dismiss button which opens a modal to select a reason and when you close the modal it scrolls back to the top of the PR review which causes you to lose your place with in the review. We are running into this issue multiple times when it catches a potential null reference issue even though it may have been checked at a higher level in the sequence of events/methods or even if its marked required at a model level but is leveraging nullability for other technical reasons. |
Beta Was this translation helpful? Give feedback.
-
|
Our initial Code Quality testing with java revealed some missing checks that we would expect from static analysis. For example try-with-resources wasn't found in a sample PR we opened. The integration between CodeQL custom queries and the Code Quality product is a bit murky. It seems like there are resource leak rules in the CodeQL repo, so we're a bit confused why we didn't get a hit. |
Beta Was this translation helpful? Give feedback.
-
|
I've been mostly sending feedback out of band, but there are two discussions to which I have access where people are talking about this feature, and it seemed like I should share some other notes: Consider: Problems:
|
Beta Was this translation helpful? Give feedback.
-
|
The github-code-quality bot appears to ignore @JsonCreator(mode = JsonCreator.Mode.PROPERTIES)
public TailormapOidcUserMixin(
@SuppressWarnings("unused") @JsonProperty("claims") Map<String, Object> claims,
@SuppressWarnings("unused") @JsonProperty("authorities") Collection<? extends GrantedAuthority> authorities,
@SuppressWarnings("unused") @JsonProperty("attributes") Map<String, Object> attributes,
@SuppressWarnings("unused") @JsonProperty("nameAttributeKey") String nameAttributeKey,
@SuppressWarnings("unused") @JsonProperty("oidcRegistrationName") String oidcRegistrationName,
@SuppressWarnings("unused") @JsonProperty("additionalGroupProperties")
Collection<TailormapAdditionalProperty> additionalGroupProperties) {
// mixin constructor only for Jackson 2; no implementation
}Annoyingly it triggers again on a file after a commit to the branch (not changing the file) and even if the comments were dismissed it will generate the comments again, creating a great deal of noise, see eg. Tailormap/tailormap-api#1536 |
Beta Was this translation helpful? Give feedback.
-
|
Hey guys, I've just published an article on Medium titled "What Is GitHub Code Quality?. This is more of an intro. I'll also have a follow-up one shortly on how to set it up and configure it. I hope you find it useful! :)
|
Beta Was this translation helpful? Give feedback.
This comment has been minimized.
This comment has been minimized.
-
|
I find this mostly useful my team has been using it for around 2 months now. However what is starting to become bother some is that we can't figure out how to disable some of the rules. If we can configure the scan the way we want we can put in restrictions etc to make this code quality metrics accurate but as is its too much false positives for us. How can I exclude some rules from the code quality scan? |
Beta Was this translation helpful? Give feedback.
-
|
I see that:
However, #1210 seems to indicate GA for this; is this or not being included in GHES 3.23? |
Beta Was this translation helpful? Give feedback.
-
|
Are there any plans to support 3rd party tools via a Sarif file (uploading them via the REST api) to use Code Quality without Copilot/CodeQL as a platform feature? |
Beta Was this translation helpful? Give feedback.
-
|
Is it possible to add instructions for GitHub Code Quality? We notice in our project that, unlike Copilot or other AI agents, GitHub Code Quality does not seem to 'listen' to any of our instructions in our See for example infonl/dimpact-zaakafhandelcomponent#5357 (review) Here the issue is in our project we use the |
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
|
Hello Github Family, we’ve been evaluating Code Quality internally and really like the direction, I personally enjoy the deep approach of base "code" quality and maintainability updates it offers.
Is support for custom rules (similar to: custom CodeQL queries, rule configuration, or similar extensibility) something that’s planned? This would be a big unlock for enterprise adoption on our side. Thanks 🚀 |
Beta Was this translation helpful? Give feedback.
-
|
Is there a way to run I have come up with this: I know So in the Problem: Having this workflow doesn't remove the dynamic one, and thus I don't control which one wins in terms of uploading its results. If mine wins, good results. If the dynamic one wins, bad results. (and I don't want to put in a sleep in mine to artificially delay it so it is always the latest...) The results above are trial and error based on `CODE_SCANNING_WORKFLOW_FILE There are probably bugs in here ( |
Beta Was this translation helpful? Give feedback.















Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
GitHub Code Quality is now available in public preview! It turns every pull request into an opportunity to improve. With in-context findings, one-click Copilot fixes, and reliability and maintainability scores, you spend less time chasing nits and more time building. It’s there when you need it most, surfacing quality issues both in the pull request and the backlog so you can fix technical debt on your schedule.
Who this is for
Developers and engineering teams who want in‑context feedback about the quality of their code and an easier way to turn technical debt into reviewable fixes.
Highlights
How to try it
Coming soon
Availability and pricing
GitHub Code Quality is available today for GitHub Enterprise Cloud and Team, but not available on Enterprise Server. It's free during the preview period, however scans will incur Actions minutes.
Learn more
Check out our GitHub Code Quality documentation
🌟Leave a comment!
Join the discussion and leave feedback in the comments below!
Disclaimer: The UI for features in public preview is subject to change.
Beta Was this translation helpful? Give feedback.
All reactions