Consider ArrayAccess side effects for dead catch analysis#5117
Open
VincentLanglet wants to merge 1 commit intophpstan:2.1.xfrom
Open
Consider ArrayAccess side effects for dead catch analysis#5117VincentLanglet wants to merge 1 commit intophpstan:2.1.xfrom
VincentLanglet wants to merge 1 commit intophpstan:2.1.xfrom
Conversation
- Synthesize offsetGet throw points in ArrayDimFetch handler for ArrayAccess objects - Synthesize offsetUnset throw points in Unset_ handler for ArrayAccess objects - Synthesize offsetExists throw points in Isset_ handler for ArrayAccess objects - offsetSet was already handled; this brings the other three operations to parity - New regression test in tests/PHPStan/Rules/Exceptions/data/bug-11427.php
Collaborator
|
This pull request has been marked as ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #4910
Closes phpstan/phpstan#11427