Set link color in dark mode to indigo by default#5206
Set link color in dark mode to indigo by default#5206ile-24556 wants to merge 3 commits intosquidfunk:masterfrom
Conversation
|
Thanks for the PR. However, 22 files changed for such a simple change doesn't look right. Please check and remove all unnecessary changes that are not necessary for the proposed change. |
|
Thank you for your quick review. I had added all the npm-built files, sorry for bothering you. I reverted the first commit and added the necessary changes. If you prefer a clean history, I would squash these commits and force push. |
|
Thanks for the PR! However, I think it's a better idea if we automatically set |
|
As an addendum: the only downside of this approach is that you now need to be explicit when using multiple color palettes: theme:
palette:
# Palette toggle for light mode
- scheme: default
primary: red
accent: red
# Palette toggle for dark mode
- scheme: slate
# The following settings are now the default, but were priorly inherited from the default scheme,
# which means that the slate theme would also use red for both values.
# primary: indigo
# accent: indigoIMHO being more explicit is better than too much magic. |
When using dark mode without setting the primary color, the link color becomes too dark (screenshot below).
This is because the default link color for light mode is used.
To avoid this, set
--md-typeset-a-colorto lighter (for-dark-mode) indigo whendata-md-color-schemeisslateanddata-md-color-primaryis empty.