Duplicate slashes in source file URLs#690
Closed
MarinBernard wants to merge 2 commits intosquidfunk:masterfrom
Closed
Duplicate slashes in source file URLs#690MarinBernard wants to merge 2 commits intosquidfunk:masterfrom
MarinBernard wants to merge 2 commits intosquidfunk:masterfrom
Conversation
Owner
|
My version of mkdocs, 0.17.2, does exhibit this behavior. However, I will provide a fix which will account for double slashes. |
Owner
|
Fixed in b3e293e. My version of MkDocs doesn't normalize the name, so I included code to handle both cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
There is an issue with source URLs built by the template from
sourceandpathpage metadata. The generated URLs include double slashes between the repository URL and the rest of the path. I don't know for Github, but Bitbucket is unable to handle such URLs correctly.The source of the issue is that the
config.repo_urlvariable is normalized by mkdocs to always include a trailing slash. As a consequence, thejoin()filter adds a trailing slash where it is not needed.The attached pull request excludes the
config.repo_urlvariable from thejoin()operation, assuming repo URLs always include a trailing slash thanks to mkdocs normalization.Thanks,
Marin.