Skip to content

chore: fix JavaScript lint errors (issue #6355)#10605

Open
chinanuj wants to merge 1 commit intostdlib-js:developfrom
chinanuj:fix-lint-issue-6355
Open

chore: fix JavaScript lint errors (issue #6355)#10605
chinanuj wants to merge 1 commit intostdlib-js:developfrom
chinanuj:fix-lint-issue-6355

Conversation

@chinanuj
Copy link

@chinanuj chinanuj commented Mar 1, 2026

Description

This PR addresses the max-lines linting failure in predicate_loops.js reported by the automated JavaScript lint workflow.

The predicate_loops.js file was previously 409 lines, exceeding the strict 300-line limit. To resolve this without altering the core logic, I refactored the script by extracting the following helper functions into their own separate files within the lib/ directory:

  • callbackBody -> lib/callback_body.js
  • signatures -> lib/signatures.js
  • updateManifest -> lib/update_manifest.js

The main script was updated to require() these modules, bringing it comfortably under the maximum line limit while maintaining the project's coding standards.

Related Issues

resolves #6355

@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Mar 1, 2026
@stdlib-bot
Copy link
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

2 participants