journal: add concept of "journal namespaces" by poettering · Pull Request #14178 · systemd/systemd

poettering · 2019-11-28T10:40:02Z

This allows multi-instantiation of journal daemons, for logical separation and performance improvement.

Mostly an implementaiton of #12123.

lgtm-com · 2019-11-28T11:03:56Z

This pull request introduces 1 alert when merging 74bc8c5 into d2a5659 - view on LGTM.com

new alerts:

1 for FIXME comment

lgtm-com · 2019-11-28T11:46:52Z

This pull request introduces 1 alert when merging 61f9cd5 into d2a5659 - view on LGTM.com

new alerts:

1 for FIXME comment

lgtm-com · 2019-11-28T14:29:37Z

This pull request introduces 1 alert when merging 16fa91d into 870a2d8 - view on LGTM.com

new alerts:

1 for FIXME comment

lgtm-com · 2019-11-28T15:15:55Z

This pull request introduces 1 alert when merging 20fc0f8 into 88eb051 - view on LGTM.com

new alerts:

1 for FIXME comment

lgtm-com · 2019-11-28T16:00:19Z

This pull request introduces 1 alert when merging 70cec3e into 88eb051 - view on LGTM.com

new alerts:

1 for FIXME comment

man/systemd-journald.service.xml

man/systemd.exec.xml

poettering · 2019-12-02T09:29:53Z

force pushed a new version with issues @boucman noticed fixed! thanks!

lgtm-com · 2019-12-02T09:55:08Z

This pull request introduces 1 alert when merging 62adc71 into cb51560 - view on LGTM.com

new alerts:

1 for FIXME comment

lgtm-com · 2019-12-04T10:24:53Z

This pull request introduces 1 alert when merging ea1d14d into 26601a2 - view on LGTM.com

new alerts:

1 for FIXME comment

lgtm-com · 2019-12-04T12:58:49Z

This pull request introduces 1 alert when merging 9d559b7 into 41ab3b7 - view on LGTM.com

new alerts:

1 for FIXME comment

anitazha

Really excited for this feature! Looks good, though I only skimmed the varlink stuff. Some minor comments.

(Also I would really appreciate if you would split the refactoring stuff into a different PR so it would be easier to focus on the feature changes vs the style/refactors...)

src/journal/journald-server.c

src/journal/journald-context.c

src/journal/journald-server.c

poettering · 2019-12-09T18:13:19Z

force pushed new version with the typo @anitazha pointed out fixed.

portante · 2019-12-09T18:16:13Z

man/journalctl.xml

      </varlistentry>

+      <varlistentry>
+        <term><option>--namespace=<replaceable>NAMESPACE</replaceable></option></term>


Can I do something like: +webserver,db,msgbus and have those three namespaces added to the default shown?

nope, currently you specify one namespace and then optionally get the default one added in, that's all. Extending this eventually to a list of namespaces is pretty easy though, but let's do that later.

portante · 2019-12-09T18:23:40Z

man/journald.conf.xml

  <refnamediv>
    <refname>journald.conf</refname>
    <refname>journald.conf.d</refname>
+    <refname>journald@.conf</refname>


What is journald@.conf vs journald@<NAMESPACE>.conf? Is that the base template file that you build into a namespace configuration?

that means nothing. It's just that the man page name is generated from what is specified here, and including <NAMESPACE> in the man page name makes it hard to type in the shell... Hence I figured we just write in in the template syntax systemd uses for units, even though it's a bit sloppy, since we don't do templating here...

man/systemd-journald.service.xml

lgtm-com · 2019-12-09T18:40:25Z

This pull request introduces 1 alert when merging 568ae03 into fb4b046 - view on LGTM.com

new alerts:

1 for FIXME comment

man/systemd-journald.service.xml

man/systemd.exec.xml

If we have exit on idle, then operations such as "journalctl --namespace=foo --rotate" should work even if the journal daemon is currently not running. (Note that we don't do activation by varlink for the main instance of journald, I am not sure the deadlocks it might introduce are worth it)

We already apply them to the directory in /var. Let's do the same in /run too. That's because due to the log namespace logic we nowadays can gain additional subdirs there during regular operation.

It doesn't get us much, but makes the differences between the templated and non-templated versions a bit smaller.

poettering · 2020-01-31T14:09:43Z

Force pushed a new version now. Addressed everything pointed out, except for the stuff I commented on, see above. No other changes.

lgtm-com · 2020-01-31T14:47:33Z

This pull request introduces 1 alert when merging ad23785 into 9a1862b - view on LGTM.com

new alerts:

1 for FIXME comment

poettering · 2020-02-01T10:25:42Z

Given that I only fixed minor stuff in the last round, and the positive reviews from multiple reviewers, and the points left to discuss can still be done after merge, and the CI is all green, taking liberty to merge this! Thanks everyone for the reviews!

evverx · 2020-02-01T18:38:12Z

Trying to run TEST-44-* under ASan/UBsan I noticed that it's flaky. As it turns out, "hello world" doesn't always end up anywhere and judging by the logs I managed to get from the container sometimes logs are just lost:

systemd-testsuite systemd[1]: systemd-journald@foobar.socket: Incoming traffic
systemd-testsuite systemd[1]: systemd-journald@foobar.socket: Suppressing connection request since unit stop is scheduled.
systemd-testsuite systemd[1]: systemd-journald@foobar.socket: Incoming traffic
systemd-testsuite systemd[1]: systemd-journald@foobar.socket: Suppressing connection request since unit stop is scheduled.
systemd-testsuite systemd[1]: systemd-journald-varlink@foobar.socket: Succeeded.

I suspect it has something to do with short-lived processes because something like

systemctl start systemd-journald@foobar
systemd-run -p LogNamespace=foobar echo 'hello world'

or

systemd-run -p LogNamespace=foobar sh -c 'echo hello world; sleep 10'

seems to always work.

I'm also wondering why systemd-journald@* are never restarted? Currently if they vanish into thin air (for whatever reason) services using log namespaces start losing logs.

poettering added journal documentation pid1 labels Nov 28, 2019

poettering force-pushed the journal-namespace branch from 74bc8c5 to 61f9cd5 Compare November 28, 2019 11:21

poettering force-pushed the journal-namespace branch from 61f9cd5 to 16fa91d Compare November 28, 2019 14:02

poettering force-pushed the journal-namespace branch from 16fa91d to 20fc0f8 Compare November 28, 2019 14:49

poettering force-pushed the journal-namespace branch from 20fc0f8 to 70cec3e Compare November 28, 2019 15:33

boucman reviewed Nov 28, 2019

View reviewed changes

man/systemd-journald.service.xml Outdated Show resolved Hide resolved

man/systemd.exec.xml Show resolved Hide resolved

poettering force-pushed the journal-namespace branch from 70cec3e to 62adc71 Compare December 2, 2019 09:29

poettering force-pushed the journal-namespace branch from 62adc71 to ea1d14d Compare December 4, 2019 09:53

poettering force-pushed the journal-namespace branch from ea1d14d to 9d559b7 Compare December 4, 2019 12:32

anitazha reviewed Dec 7, 2019

View reviewed changes

src/journal/journald-server.c Show resolved Hide resolved

src/journal/journald-context.c Outdated Show resolved Hide resolved

src/journal/journald-server.c Show resolved Hide resolved

poettering force-pushed the journal-namespace branch from 9d559b7 to 568ae03 Compare December 9, 2019 18:11

portante reviewed Dec 9, 2019

View reviewed changes

man/systemd-journald.service.xml Outdated Show resolved Hide resolved

portante reviewed Dec 9, 2019

View reviewed changes

man/systemd-journald.service.xml Outdated Show resolved Hide resolved

portante reviewed Dec 9, 2019

View reviewed changes

man/systemd-journald.service.xml Outdated Show resolved Hide resolved

portante reviewed Dec 9, 2019

View reviewed changes

man/systemd.exec.xml Show resolved Hide resolved

poettering added 10 commits January 31, 2020 15:03

journald: use structured initialization

d98580e

varlink: add API for determining number of current connections

c4f601f

varlink: add ability to register callback for disconnections

6d4d600

journald: add exit on idle

65c398c

test: add simple test for log namespaces

db23d83

tmpfiles: merge lines for the same inodes

0f5a4f9

tmpfiles: apply ACLs to top-level journal directory in /run, too

fb38a7b

We already apply them to the directory in /var. Let's do the same in /run too. That's because due to the log namespace logic we nowadays can gain additional subdirs there during regular operation.

units: sort settings in systemd-journald.service again

5591cd4

units: define RuntimeDirectory= in systemd-journald.service

340cb11

It doesn't get us much, but makes the differences between the templated and non-templated versions a bit smaller.

poettering force-pushed the journal-namespace branch from 75491f3 to 1bd91d4 Compare January 31, 2020 14:08

poettering added 8 commits January 31, 2020 15:10

journalctl: underline sections in --help

23d8c56

man: document journald namespaces

efcbcd0

man: document journald@NAMESPACE.conf

6bc4361

man: document new _NAMESPACE= journal field

7d8155b

man: document LogNamespace= unit setting

5b0a76d

man: document the new sd_journal_open_namespace() API

241c8f6

man: document --namespace= switch of journalctl

2b6b8bd

update TODO

ad23785

poettering force-pushed the journal-namespace branch from 1bd91d4 to ad23785 Compare January 31, 2020 14:12

poettering merged commit 5ee69e1 into systemd:master Feb 1, 2020

mbiebl mentioned this pull request Feb 6, 2020

"test_rsyslog (__main__.ServicesTest) ... FAIL" due to syslog forwarding being broken #14799

Closed

evverx mentioned this pull request Mar 19, 2020

tests: temporarily bring back the ASan+UBsan stage to run TEST-44-LOG… #14734

Closed

mrc0mmand mentioned this pull request Apr 22, 2020

journalctl --file=/var/log/journal/*/* --follow -> Segmentation fault #15528

Closed

bjoe2k4 mentioned this pull request May 20, 2020

Implement journal namespaces syslog-ng/syslog-ng#3296

Closed

Meulengracht mentioned this pull request Nov 9, 2022

journald: allow flushing namespaces from /run to /var #25320

Open

Uh oh!

Conversation

poettering commented Nov 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lgtm-com bot commented Nov 28, 2019

Uh oh!

lgtm-com bot commented Nov 28, 2019

Uh oh!

lgtm-com bot commented Nov 28, 2019

Uh oh!

lgtm-com bot commented Nov 28, 2019

Uh oh!

lgtm-com bot commented Nov 28, 2019

Uh oh!

Uh oh!

Uh oh!

poettering commented Dec 2, 2019

Uh oh!

lgtm-com bot commented Dec 2, 2019

Uh oh!

lgtm-com bot commented Dec 4, 2019

Uh oh!

lgtm-com bot commented Dec 4, 2019

Uh oh!

anitazha left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

poettering commented Dec 9, 2019

Uh oh!

portante Dec 9, 2019

Choose a reason for hiding this comment

Uh oh!

poettering Dec 9, 2019

Choose a reason for hiding this comment

Uh oh!

portante Dec 9, 2019

Choose a reason for hiding this comment

Uh oh!

poettering Dec 9, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lgtm-com bot commented Dec 9, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

poettering commented Jan 31, 2020

Uh oh!

lgtm-com bot commented Jan 31, 2020

Uh oh!

poettering commented Feb 1, 2020

Uh oh!

evverx commented Feb 1, 2020

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

7 participants

poettering commented Nov 28, 2019 •

edited

Loading

anitazha left a comment •

edited

Loading