udev,sd-device: drop old database support#40801
Open
yuwata wants to merge 3 commits intosystemd:mainfrom
Open
Conversation
The udev database versioning has been introduced in v247, which is released on 2020-11-26. Let's drop the support of old udev database.
The mapping from device ID to watch handle has been introduced by e7f781e (v249, released on 2021-07-07). Let's drop the runtime upgradability of udevd from an ancient version.
The new file format in /run/udev/links/ has been introduced in 377a83f (v250, released on 2021-12-23). Let's drop the old format support, to simplify the logic.
95ce48b to
b8e3b8f
Compare
keszybz
reviewed
Mar 2, 2026
|
|
||
| /* This reads priority and device node from the symlink under /run/udev/links (or udev database). | ||
| /* This reads priority and device node from the symlink under /run/udev/links/ directory. | ||
| * If 'devnode' is NULL, obtained priority is always set to '*priority'. If 'devnode' is non-NULL, |
Member
There was a problem hiding this comment.
Existing issue, of course, but this sentence is backwards: the obtained priority is saved to '*priority'.
So maybe say "If 'devnode' is NULL, *priority is always set the the obtained priority.".
keszybz
approved these changes
Mar 2, 2026
Member
keszybz
left a comment
There was a problem hiding this comment.
LGTM.
I'd have a slight preference to merge this after v260, mostly becuase we're already after -rc1 and should be doing -rc2 soon and it's better to minimize big changes. We don't touch this area of the code very often so there shouldn't be a lot of problem with rebasing. But if you think it should go in now, I'd be fine with that too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing #40776.