Add cats effect laws checking for cats interop [WIP]#19
Open
jchapuis wants to merge 1 commit intotmccarthy:masterfrom
Open
Add cats effect laws checking for cats interop [WIP]#19jchapuis wants to merge 1 commit intotmccarthy:masterfrom
jchapuis wants to merge 1 commit intotmccarthy:masterfrom
Conversation
Author
|
@tmccarthy this is the one with the cats-effect laws. As mentioned, there are some failures - but I did not investigate wether these failures are legitimate or not. I suspect they could be. Maybe you could have an eye at the build? |
Owner
|
Sorry @jchapuis I didn't realise this PR was different from the other one! I think these are genuine failures. Ideally I think we would ignore those particular tests and merge this PR, with issues raised to fix the underlying issues. I'll see if I can get the chance to have a closer look in the next few days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one has some failures - I'm not sure what's the problem, the test setup or some real flaw