fix(deps): Update the Java code generator (gapic-generator-java) to 2.31.0 by gcf-owl-bot[bot] · Pull Request #2349 · googleapis/java-storage

gcf-owl-bot · 2024-01-06T04:52:10Z

Regenerate this pull request now.

PiperOrigin-RevId: 596645164

Source-Link: googleapis/googleapis@4a0e62e

Source-Link: https://github.com/googleapis/googleapis-gen/commit/a10ed6a77676c37e60799098d48d0afb16008613
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYTEwZWQ2YTc3Njc2YzM3ZTYwNzk5MDk4ZDQ4ZDBhZmIxNjAwODYxMyJ9

feat: add Storage Control API

PiperOrigin-RevId: 596130676

Source-Link: googleapis/googleapis@ce07d24

Source-Link: https://github.com/googleapis/googleapis-gen/commit/7de5bf064581832c3fff93ab51b4c0b1d0d14aa1
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2RlNWJmMDY0NTgxODMyYzNmZmY5M2FiNTFiNGMwYjFkMGQxNGFhMSJ9

frankyn · 2024-01-08T17:23:47Z

Hi @suztomo, PR is missing grpc artifact IIUC comparing it against storage-v2;

suztomo · 2024-01-08T19:24:41Z

Hi @suztomo, PR is missing grpc artifact IIUC comparing it against storage-v2;

I thought we didn't need it so I didn't add grpc- part in https://github.com/googleapis/java-storage/pull/2347/files. Do you need it?

suztomo · 2024-01-08T19:30:58Z

"ci / dependencies (17)" failed https://github.com/googleapis/java-storage/actions/runs/7429540884/job/20218238157?pr=2349.

[INFO] --- maven-dependency-plugin:3.5.0:analyze (default-cli) @ proto-google-cloud-storage-control-v2 ---
Error:  Unused declared dependencies found:
Error:     com.google.api.grpc:proto-google-iam-v1:jar:1.24.0:compile

This is just a matter of removing the unused dependency from the pom.xml.

suztomo · 2024-01-08T20:28:08Z

pom.xml

    <module>google-cloud-storage</module>
    <module>grpc-google-cloud-storage-v2</module>
    <module>proto-google-cloud-storage-v2</module>
+    <module>proto-google-cloud-storage-control-v2</module>


@sydney-munro google-cloud-storage-control module is missing. Would you add it?

suztomo

@sydney-munro google-cloud-storage-control is missing pom.xml. Can you create one by copying contents from https://github.com/googleapis/java-storage/blob/main/gapic-google-cloud-storage-v2/pom.xml (You need to edit artifact IDs and might need to adjust dependencies) If that's a trouble for you, I can help.

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

…rage into owl-bot-copy

suztomo · 2024-01-09T18:38:24Z

google-cloud-storage-control/pom.xml

+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <modelVersion>4.0.0</modelVersion>
+    <groupId>com.google.cloud</groupId>


Group ID is good.

gcf-owl-bot bot added the owl-bot-copy label Jan 6, 2024

trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 6, 2024

product-auto-label bot added the size: xl Pull request size is extra large. label Jan 6, 2024

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 6, 2024

product-auto-label bot added the api: storage Issues related to the googleapis/java-storage API. label Jan 6, 2024

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 6, 2024

gcf-owl-bot bot marked this pull request as ready for review January 6, 2024 04:54

gcf-owl-bot bot requested review from a team January 6, 2024 04:54

trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 6, 2024

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 6, 2024

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 6, 2024

frankyn requested review from suztomo and sydney-munro January 8, 2024 17:23

sydney-munro approved these changes Jan 8, 2024

View reviewed changes

sydney-munro added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 8, 2024

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 8, 2024

trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 8, 2024

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 8, 2024

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 8, 2024

suztomo requested changes Jan 8, 2024

View reviewed changes

gcf-owl-bot bot changed the title ~~feat: add Storage Control API~~ fix(deps): Update the Java code generator (gapic-generator-java) to 2.31.0 Jan 8, 2024

trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 8, 2024