This repository was archived by the owner on Sep 26, 2023. It is now read-only.
fix: Preconditions only supports %s format#1153
Merged
noahdietz merged 1 commit intogoogleapis:masterfrom Jul 21, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1153 +/- ##
=========================================
Coverage 78.65% 78.65%
Complexity 1170 1170
=========================================
Files 204 204
Lines 5195 5195
Branches 417 417
=========================================
Hits 4086 4086
Misses 935 935
Partials 174 174
Continue to review full report at Codecov.
|
miraleung
approved these changes
Jul 21, 2020
miraleung
reviewed
Jul 21, 2020
Contributor
miraleung
left a comment
There was a problem hiding this comment.
Alternatively, String.format("Pool size ... %d", MAX_POOL_SIZE)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preconditionsonly support use of the%sformat specifier (docs) and gax-java had a%dformat specifier. This switches it to%s.The following error showed up in bazel builds of
java_gapic_librarytargets on HEAD of googleapis:I'm not sure what changed, maybe the dependency version brought was updated transiently to the later versions that throw an exception on format specifier support in
Preconditions. Regardless, this is an easy fix.