fix: use random UUID for multipart boundary delimiter#916
Merged
chingor13 merged 2 commits intogoogleapis:masterfrom Dec 30, 2019
Merged
fix: use random UUID for multipart boundary delimiter#916chingor13 merged 2 commits intogoogleapis:masterfrom
chingor13 merged 2 commits intogoogleapis:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
d4b8f7d to
787b159
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
787b159 to
9971579
Compare
elharo
reviewed
Dec 30, 2019
|
|
||
| public MultipartContent() { | ||
| super(new HttpMediaType("multipart/related").setParameter("boundary", "__END_OF_PART__")); | ||
| this("__END_OF_PART__" + java.util.UUID.randomUUID().toString() + "__"); |
Contributor
There was a problem hiding this comment.
Is there a reason not to import java.util.UUID? e.g a conflict with a similarly named class?
| {"<xml>Hi</xml>", "application/xml"}, | ||
| {"{x:1,y:2}", "application/json"} | ||
| }; | ||
| StringBuilder expectedContentSB = new StringBuilder(); |
Contributor
There was a problem hiding this comment.
no abbreviations per google style, but simply "expectedContent" or even just expected is fine.
Contributor
Author
There was a problem hiding this comment.
expectedContent is used later. renamed to expectedStringBuilder
| ByteArrayOutputStream out = new ByteArrayOutputStream(); | ||
| content.writeTo(out); | ||
| String expectedContent = expectedContentSB.toString(); | ||
| assertEquals(expectedContent, out.toString()); |
Contributor
There was a problem hiding this comment.
out.toString needs to specify a locale
Contributor
Author
There was a problem hiding this comment.
fixed in two places. Thanks for catching that.
elharo
approved these changes
Dec 30, 2019
clundin25
pushed a commit
to clundin25/google-http-java-client
that referenced
this pull request
Aug 11, 2022
…en-plugin to v1.6.13 (googleapis#916) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.sonatype.plugins:nexus-staging-maven-plugin](http://www.sonatype.com/) ([source](https://togithub.com/sonatype/nexus-maven-plugins)) | `1.6.12` -> `1.6.13` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>sonatype/nexus-maven-plugins</summary> ### [`v1.6.13`](https://togithub.com/sonatype/nexus-maven-plugins/compare/release-1.6.12...release-1.6.13) [Compare Source](https://togithub.com/sonatype/nexus-maven-plugins/compare/release-1.6.12...release-1.6.13) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/google-auth-library-java).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #909
Fixes googleapis/google-cloud-java#6386