Skip to content

docs: update libraries-bom#140

Merged
anguillanneuf merged 1 commit intomasterfrom
anguillanneuf-patch-1
Apr 10, 2020
Merged

docs: update libraries-bom#140
anguillanneuf merged 1 commit intomasterfrom
anguillanneuf-patch-1

Conversation

@anguillanneuf
Copy link
Contributor

@anguillanneuf anguillanneuf commented Apr 10, 2020 •
edited
Loading

Is the libraries-bom update automated in any way? I suspect our docs page reads directly from here.

The tests took over hours to finish. Is there a way to skip some of these tests for README changes?

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 10, 2020
@anguillanneuf anguillanneuf changed the title Update libraries-bom docs: update libraries-bom Apr 10, 2020
@anguillanneuf anguillanneuf force-pushed the anguillanneuf-patch-1 branch from b99095c to b991726 Compare April 10, 2020 17:02
@codecov
Copy link

codecov bot commented Apr 10, 2020 •
edited
Loading

Codecov Report

Merging #140 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #140   +/-   ##
=========================================
  Coverage     78.37%   78.37%           
  Complexity      302      302           
=========================================
  Files            21       21           
  Lines          2719     2719           
  Branches        134      134           
=========================================
  Hits           2131     2131           
  Misses          513      513           
  Partials         75       75

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29e26ea...b991726. Read the comment docs.

elharo
elharo approved these changes Apr 10, 2020
View reviewed changes
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It should be auto-updated but sometimes the autoupdater seems to miss things.

There's no way to skip the tests. You'd be surprised the bugs a simple change in the README can uncover.

@anguillanneuf anguillanneuf added type: docs Improvement to the documentation for an API. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 10, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 10, 2020
@anguillanneuf
Copy link
Contributor Author

anguillanneuf commented Apr 10, 2020 •
edited
Loading

@elharo Thanks for approving the PR. I started a rerun to see if they will pass this time.
Could you point me to the autoupdater so I could take a look for this library?

Looks like Kokoro - Test: Java 8 is the problem. Looking at the log, is com.google.cloud.pubsub.v1.PublisherImplTest the issue?

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running com.google.cloud.pubsub.v1.SubscriptionAdminClientTest
[INFO] Tests run: 36, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.356 s - in com.google.cloud.pubsub.v1.SubscriptionAdminClientTest
[INFO] Running com.google.cloud.pubsub.v1.PublisherImplTest


ERROR: Aborting VM command due to timeout of 10800 seconds

@elharo
Copy link
Contributor

elharo commented Apr 10, 2020

You can ask @chingor13 about the auto-updater.

@elharo elharo added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 10, 2020
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 10, 2020
@anguillanneuf anguillanneuf merged commit d8239bd into master Apr 10, 2020
@anguillanneuf anguillanneuf deleted the anguillanneuf-patch-1 branch April 10, 2020 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hannahrogers-google hannahrogers-google Awaiting requested review from hannahrogers-google

1 more reviewer

@elharo elharo elharo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@anguillanneuf @elharo @googlebot @yoshi-kokoro