Skip to content

feat: add schema service to gapic#494

Merged
hongalex merged 3 commits intomasterfrom
autosynth-googleapis
Feb 2, 2021
Merged

feat: add schema service to gapic#494
hongalex merged 3 commits intomasterfrom
autosynth-googleapis

Conversation

@yoshi-automation
Copy link
Contributor

@yoshi-automation yoshi-automation commented Jan 28, 2021 •
edited
Loading

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/7db1b505-cc01-4a40-953b-c51c69223c3a/targets

  • To automatically regenerate this PR, check this box.

PiperOrigin-RevId: 348038736
Source-Link: googleapis/googleapis@41d8fbf
PiperOrigin-RevId: 336174031
Source-Link: googleapis/googleapis@bf79839

@yoshi-automation yoshi-automation requested review from a team January 28, 2021 23:46
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/java-pubsub API. label Jan 28, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 28, 2021
@hongalex hongalex changed the title [CHANGE ME] Re-generated to pick up changes from googleapis. feat: add schema service to gapic Jan 29, 2021
@hongalex hongalex added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 1, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 1, 2021
@codecov
Copy link

codecov bot commented Feb 1, 2021 •
edited
Loading

Codecov Report

Merging #494 (6e55532) into master (4123f26) will decrease coverage by 0.35%.
The diff coverage is 80.10%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #494      +/-   ##
============================================
- Coverage     79.14%   78.79%   -0.36%     
- Complexity      323      376      +53     
============================================
  Files            21       27       +6     
  Lines          2925     3414     +489     
  Branches        166      171       +5     
============================================
+ Hits           2315     2690     +375     
- Misses          541      651     +110     
- Partials         69       73       +4
Impacted Files Coverage Δ Complexity Δ
...oogle/cloud/pubsub/v1/SubscriptionAdminClient.java 63.06% <ø> (ø) 52.00 <0.00> (ø)
...a/com/google/cloud/pubsub/v1/TopicAdminClient.java 58.95% <ø> (ø) 34.00 <0.00> (ø)
...google/cloud/pubsub/v1/stub/SchemaServiceStub.java 12.50% <12.50%> (ø) 1.00 <1.00> (?)
.../google/cloud/pubsub/v1/SchemaServiceSettings.java 17.94% <17.94%> (ø) 2.00 <2.00> (?)
...bsub/v1/stub/GrpcSchemaServiceCallableFactory.java 37.50% <37.50%> (ø) 3.00 <3.00> (?)
...om/google/cloud/pubsub/v1/SchemaServiceClient.java 60.91% <60.91%> (ø) 20.00 <20.00> (?)
...loud/pubsub/v1/stub/SchemaServiceStubSettings.java 86.69% <86.69%> (ø) 15.00 <15.00> (?)
...le/cloud/pubsub/v1/stub/GrpcSchemaServiceStub.java 93.43% <93.43%> (ø) 12.00 <12.00> (?)
...le/cloud/pubsub/v1/stub/PublisherStubSettings.java 83.95% <100.00%> (+0.39%) 21.00 <0.00> (ø)
...e/cloud/pubsub/v1/stub/SubscriberStubSettings.java 85.32% <100.00%> (ø) 28.00 <0.00> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4123f26...39ab03d. Read the comment docs.

@hongalex
Copy link
Member

hongalex commented Feb 1, 2021

@hannahrogers-google @kamalaboulhosn This is this PR started to add schema support. It seems to be failing due to code coverage issues, could you take a look?

@yoshi-automation
changes without context
fcf8da4 
        autosynth cannot find the source of changes triggered by earlier changes in this
        repository, or by version upgrades to tools such as linters.
@yoshi-automation
fix: switch pubsub/v1 retry config to grpc_service_config
8e1b1c1 
PiperOrigin-RevId: 336174031

Source-Author: Google APIs <noreply@google.com>
Source-Date: Thu Oct 8 15:10:41 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: bf79839b947d8b5c0f55516b963433faf23b54c4
Source-Link: googleapis/googleapis@bf79839
@yoshi-automation
feat: add schema service
39ab03d 
PiperOrigin-RevId: 348038736

Source-Author: Google APIs <noreply@google.com>
Source-Date: Thu Dec 17 09:47:03 2020 -0800
Source-Repo: googleapis/googleapis
Source-Sha: 41d8fbfec9d4bc4a8859f78185713950913b4bf3
Source-Link: googleapis/googleapis@41d8fbf
@hongalex hongalex merged commit 23952bf into master Feb 2, 2021
@hongalex hongalex deleted the autosynth-googleapis branch February 2, 2021 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hongalex hongalex hongalex approved these changes

Assignees

No one assigned

Labels

api: pubsub Issues related to the googleapis/java-pubsub API. cla: yes This human has signed the Contributor License Agreement. context: full context: partial

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yoshi-automation @hongalex @yoshi-kokoro