feat: transaction callable as functional interface#1066
Merged
thiagotnunes merged 2 commits intogoogleapis:masterfrom Apr 15, 2021
Merged
Conversation
Marks the transaction callable as a functional interface.
Codecov Report
@@ Coverage Diff @@
## master #1066 +/- ##
=========================================
Coverage 85.24% 85.25%
- Complexity 2658 2660 +2
=========================================
Files 155 155
Lines 14453 14448 -5
Branches 1362 1362
=========================================
- Hits 12320 12317 -3
+ Misses 1565 1562 -3
- Partials 568 569 +1
Continue to review full report at Codecov.
|
olavloite
approved these changes
Apr 15, 2021
Collaborator
olavloite
left a comment
There was a problem hiding this comment.
LGTM.
We should also update the examples in the Javadoc in the DatabaseClient interface (and possibly also other places), but I think we can do that in a separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the
TransactionCallablea@FunctionalInterfaceso it can be used with lambdas.This PR also modifies all of its usages to the lambda syntax. Only syntatic changes were made, no logic changes were made here.