fix: always delete all backups from an owned test instance#557
Merged
thiagotnunes merged 2 commits intomasterfrom Oct 27, 2020
Merged
fix: always delete all backups from an owned test instance#557thiagotnunes merged 2 commits intomasterfrom
thiagotnunes merged 2 commits intomasterfrom
Conversation
An instance can only be deleted once all backups on the instance have been deleted. The integration test environment should therefore first delete all backups on an owned instance before trying to delete the instance itself. Fixes #542
Codecov Report
@@ Coverage Diff @@
## master #557 +/- ##
============================================
+ Coverage 83.93% 84.03% +0.10%
- Complexity 2501 2503 +2
============================================
Files 141 141
Lines 13766 13806 +40
Branches 1315 1317 +2
============================================
+ Hits 11554 11602 +48
+ Misses 1667 1657 -10
- Partials 545 547 +2
Continue to review full report at Codecov.
|
hengfengli
approved these changes
Oct 27, 2020
Contributor
hengfengli
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing this issue.
thiagotnunes
approved these changes
Oct 27, 2020
Contributor
thiagotnunes
left a comment
There was a problem hiding this comment.
Thanks for the fix!
ansh0l
pushed a commit
to ansh0l/java-spanner
that referenced
this pull request
Nov 10, 2022
This is an auto-generated regeneration of the .pb.go files by cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will update the corresponding PR to depend on the newer version of go-genproto, and assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot will not create any more regeneration PRs. If all regen PRs are closed, gapicgen will create a new set of regeneration PRs once per night. If you have been assigned to review this PR, please: - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. That will prompt genbot to assign reviewers to the google-cloud-go PR. Corresponding google-cloud-go PR: googleapis/google-cloud-go#3849 Changes: feat(monitoring/apiv3): Added support for Monitoring Query Language: https://cloud.google.com/monitoring/mql feat: Added support for units in the MetricService feat: Added total_size to the response of ListAlertPolicies. fix: Un-deprecated cluster_istio for service monitoring. feat: Added IstioCanonicalService for service monitoring. feat: Added creation and mutation records to notification channels. feat: Added support for querying metrics for folders and organizations. fix: Extended the default deadline for UpdateGroup to 180s. feat: Added support for secondary aggregation when querying metrics. PiperOrigin-RevId: 364422694 Source-Link: googleapis/googleapis@2124b62 chore: upgrade gapic-generator-python to 0.43.1 PiperOrigin-RevId: 364411656 Source-Link: googleapis/googleapis@149a3a8 feat: Add TAXI travel mode and PolylineEncoding. PiperOrigin-RevId: 364401367 Source-Link: googleapis/googleapis@961dc7c feat: added v3beta1 proto for online and batch document translation PiperOrigin-RevId: 364358156 Source-Link: googleapis/googleapis@d6b4fb3 docs(dialogflow): fix link for version and environment in participant doc. fix: Add all missing regional HTTP bindings in DF API. PiperOrigin-RevId: 364356707 Source-Link: googleapis/googleapis@5ef92c3 fix!(dialogflow): Remove resource_reference from UpdateAnswerRecord. Committer: @sheimi PiperOrigin-RevId: 363947872 Source-Link: googleapis/googleapis@5da78db
rajatbhatta
pushed a commit
to rajatbhatta/java-spanner
that referenced
this pull request
Nov 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An instance can only be deleted once all backups on the instance have been deleted. The integration test environment should therefore first delete all backups on an owned instance before trying to delete the instance itself.
Individual test cases are responsible for deleting any backups that are created during the test, but sometimes backup creation operations do not finish within reasonable time. The deletion of these backups by the individual test cases sometimes seem to fail. This change is an additional fallback for making sure that all backups that were created during the tests are removed, and that the test instance can be removed.
Fixes #542