fix: prevent NPE in RemoteStorageHelper.cleanBuckets#492
Merged
frankyn merged 1 commit intogoogleapis:masterfrom Sep 1, 2020
Merged
fix: prevent NPE in RemoteStorageHelper.cleanBuckets#492frankyn merged 1 commit intogoogleapis:masterfrom
frankyn merged 1 commit intogoogleapis:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #492 +/- ##
============================================
- Coverage 64.60% 64.59% -0.02%
+ Complexity 626 617 -9
============================================
Files 32 32
Lines 5235 5236 +1
Branches 506 508 +2
============================================
Hits 3382 3382
- Misses 1694 1695 +1
Partials 159 159
Continue to review full report at Codecov.
|
The method getEventBasedHold and getTemporaryHold return Boolean objects which are either true, false or null. In case of a null value, this produced a NPE.
frankyn
approved these changes
Sep 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method
getEventBasedHoldandgetTemporaryHoldreturnBooleanobjects which are eithertrue,falseornull. In case of anullvalue, this produced a NPE.