fix: executemany rowcount only reflected the last execution (#660)

Jim Fulton · web-flow · commit aeadc8c2d614 · 2021-05-12T12:22:20.000+02:00
diff --git a/google/cloud/bigquery/dbapi/cursor.py b/google/cloud/bigquery/dbapi/cursor.py
@@ -218,6 +218,7 @@ def executemany(self, operation, seq_of_parameters):
                 Sequence of many sets of parameter values.
         """
         if seq_of_parameters:
+            rowcount = 0
             # There's no reason to format the line more than once, as
             # the operation only barely depends on the parameters.  So
             # we just use the first set of parameters. If there are
@@ -230,6 +231,9 @@ def executemany(self, operation, seq_of_parameters):
                 self._execute(
                     formatted_operation, parameters, None, None, parameter_types
                 )
+                rowcount += self.rowcount
+
+            self.rowcount = rowcount
 
     def _try_fetch(self, size=None):
         """Try to start fetching data, if not yet started.
diff --git a/tests/unit/test_dbapi_cursor.py b/tests/unit/test_dbapi_cursor.py
@@ -612,7 +612,7 @@ def test_executemany_w_dml(self):
             (("test",), ("anothertest",)),
         )
         self.assertIsNone(cursor.description)
-        self.assertEqual(cursor.rowcount, 12)
+        self.assertEqual(cursor.rowcount, 24)  # 24 because 2 * 12 because cumulatve.
 
     def test_executemany_empty(self):
         from google.cloud.bigquery.dbapi import connect

Original file line number	Diff line number	Diff line change
`@@ -612,7 +612,7 @@ def test_executemany_w_dml(self):`
`612`	`612`	`(("test",), ("anothertest",)),`
`613`	`613`	`)`
`614`	`614`	`self.assertIsNone(cursor.description)`
`615`		`- self.assertEqual(cursor.rowcount, 12)`
	`615`	`+ self.assertEqual(cursor.rowcount, 24) # 24 because 2 * 12 because cumulatve.`
`616`	`616`
`617`	`617`	`def test_executemany_empty(self):`
`618`	`618`	`from google.cloud.bigquery.dbapi import connect`