docs(bigquery): add client thread-safety documentation#132
Merged
HemangChothani merged 3 commits intogoogleapis:masterfrom Jun 15, 2020
Merged
docs(bigquery): add client thread-safety documentation#132HemangChothani merged 3 commits intogoogleapis:masterfrom
HemangChothani merged 3 commits intogoogleapis:masterfrom
Conversation
plamut
reviewed
Jun 11, 2020
Contributor
plamut
left a comment
There was a problem hiding this comment.
Just two nits (disclaimer: I'm not a native speaker).
As for the thread safety, I scanned the Client code and it does not really have much state, except for a few internal properties and the project attribute. There is also the close() method, but that just operates on requests objects or their subclasses, e.g. google.auth.transport.AuthorizedSession.
Using a shared client is thus (probably) fine.
plamut
approved these changes
Jun 12, 2020
Contributor
plamut
left a comment
There was a problem hiding this comment.
LGTM. Decide on your own if we need to change the spelling, since I'm not sure if my remark is indeed valid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #129